[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH COLO v3 08/14] Allow creating backup jobs when o
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH COLO v3 08/14] Allow creating backup jobs when opening BDS |
Date: |
Fri, 03 Apr 2015 13:06:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/04/2015 12:01, Wen Congyang wrote:
> When opening BDS, we need to create backup jobs for
> image-fleecing. This feature is not used by qemu-img,
> qemu-io or qemu-nbd. So just adding the referenced
> functions to stubs.
>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> stubs/Makefile.objs | 1 +
> stubs/backup.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
> create mode 100644 stubs/backup.c
>
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index 8beff4c..5ae2214 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -39,3 +39,4 @@ stub-obj-$(CONFIG_WIN32) += fd-register.o
> stub-obj-y += cpus.o
> stub-obj-y += kvm.o
> stub-obj-y += qmp_pc_dimm_device_list.o
> +stub-obj-y += backup.o
> diff --git a/stubs/backup.c b/stubs/backup.c
> new file mode 100644
> index 0000000..3ebcc71
> --- /dev/null
> +++ b/stubs/backup.c
> @@ -0,0 +1,11 @@
> +#include "block/block_int.h"
> +
> +void backup_start(BlockDriverState *bs, BlockDriverState *target,
> + int64_t speed, MirrorSyncMode sync_mode,
> + BlockdevOnError on_source_error,
> + BlockdevOnError on_target_error,
> + BlockCompletionFunc *cb, void *opaque,
> + Error **errp)
> +{
> + error_setg(errp, "this feature or command is not currently supported");
> +}
>
I wouldn't mind just moving block/backup.o from common-objs-y to
block-objs-y.
Paolo
Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description, Dr. David Alan Gilbert, 2015/04/22
[Qemu-block] [PATCH COLO v3 05/14] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 03/14] NBD client: connect to nbd server later, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 07/14] allow writing to the backing file, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 08/14] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/04/03
- Re: [Qemu-block] [PATCH COLO v3 08/14] Allow creating backup jobs when opening BDS,
Paolo Bonzini <=
[Qemu-block] [PATCH COLO v3 04/14] Add new block driver interfaces to control block replication, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 11/14] Backup: clear all bitmap when doing block checkpoint, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 10/14] util/hbitmap: Add an API to reset all set bits in hbitmap, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 14/14] Don't allow a disk use backing reference target, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 13/14] skip nbd_target when starting block replication, Wen Congyang, 2015/04/03
[Qemu-block] [PATCH COLO v3 09/14] block: Parse "backing_reference" option to reference existing BDS, Wen Congyang, 2015/04/03