Re: [Qemu-block] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures

[Stefan Hajnoczi]

On Thu, Mar 19, 2015 at 08:24:12PM -0400, John Snow wrote:
> Two issues were unearthed from ahci-test on ppc64:
> 
> (1) The ahci_populate_sglist function had endian issues,
>     which is only likely to impact PIO transfers for buffers
>     greater than one sector, and
> 
> (2) multiple-sector PIO which I attempted to repair in
>     36334faf has been broken for years. ahci-test didn't catch
>     this because it used a pattern that was identical for each
>     sector.
> 
>     So the pattern has been corrected and the underlying issue
>     fixed.
> 
> This should clear up the test failures (properly) for ppc64.
> 
> John Snow (4):
>   ide: fix cmd_write_pio when nsectors > 1
>   ide: fix cmd_read_pio when nsectors > 1
>   ahci: Fix sglist offset manipulation for BE machines
>   ahci-test: improve rw buffer patterns
> 
>  hw/ide/ahci.c     |  2 +-
>  hw/ide/core.c     | 10 ++++------
>  tests/ahci-test.c | 36 ++++++++++++++++++++++++++++--------
>  3 files changed, 33 insertions(+), 15 deletions(-)
> 
> -- 
> 2.1.0
> 

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpBXc7PKU45t.pgp
Description: PGP signature