[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 62/73] virtio-blk: Remove the stale FIXME comment
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 62/73] virtio-blk: Remove the stale FIXME comment |
Date: |
Mon, 9 Mar 2015 16:41:47 +0100 |
From: Fam Zheng <address@hidden>
By default, we have ioeventfd enabled, so the IO request processing is
in IO thread; in the vcpu thread, guest mode is returned to as quickly
as possible, and completion is delivered via irqfd. Therefore this
comment from the initial implementation is barely relevant.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/block/virtio-blk.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 7b0b653..24ada67 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -597,12 +597,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev,
VirtQueue *vq)
if (mrb.num_reqs) {
virtio_blk_submit_multireq(s->blk, &mrb);
}
-
- /*
- * FIXME: Want to check for completions before returning to guest mode,
- * so cached reads and writes are reported as quickly as possible. But
- * that should be done in the generic block layer.
- */
}
static void virtio_blk_dma_restart_bh(void *opaque)
--
1.8.3.1
- [Qemu-block] [PULL 00/73] Block patches, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 65/73] iotests: Drop vpc from 004's and 104's format list, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 62/73] virtio-blk: Remove the stale FIXME comment,
Kevin Wolf <=
- [Qemu-block] [PULL 66/73] block/vdi: Add locking for parallel requests, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 70/73] MAINTAINERS: Add jsnow as IDE maintainer, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 64/73] iotests: Remove 006, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 71/73] block/raw-posix: fix launching with failed disks, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 22/73] qcow2: Helper function for refcount modification, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 63/73] iotests: Fix 051's reference output, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 67/73] scsi-hd: fix property unset case, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 72/73] iotests: add O_DIRECT alignment probing test, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 68/73] Add testcase for scsi-hd devices without drive property, Kevin Wolf, 2015/03/09
- [Qemu-block] [PULL 73/73] MAINTAINERS: Add jcody as blockjobs, block devices maintainer, Kevin Wolf, 2015/03/09