qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/22] target/arm/tcg: Reduce 'helper-vfp.h.inc' inclusion


From: Richard Henderson
Subject: Re: [PATCH 11/22] target/arm/tcg: Reduce 'helper-vfp.h.inc' inclusion
Date: Fri, 9 Jun 2023 12:04:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 6/9/23 03:47, Philippe Mathieu-Daudé wrote:
Instead of including helper-vfp.h.inc via helper.h which
is included by all TCG files, restrict it to the few files
that require it.

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
---
  target/arm/helper.h             | 1 -
  target/arm/tcg/mve_helper.c     | 5 +++++
  target/arm/tcg/sve_helper.c     | 4 ++++
  target/arm/tcg/translate-a64.c  | 5 +++++
  target/arm/tcg/translate-neon.c | 5 +++++
  target/arm/tcg/translate-vfp.c  | 6 ++++++
  target/arm/tcg/vec_helper.c     | 5 +++++
  target/arm/vfp_helper.c         | 5 +++++
  8 files changed, 35 insertions(+), 1 deletion(-)

diff --git a/target/arm/helper.h b/target/arm/helper.h
index 9d85675d17..4d1b7ec6b4 100644
--- a/target/arm/helper.h
+++ b/target/arm/helper.h
@@ -813,5 +813,4 @@ DEF_HELPER_FLAGS_5(gvec_uclamp_d, TCG_CALL_NO_RWG,
  #include "tcg/helper-sme.h.inc"
  #endif
-#include "tcg/helper-vfp.h.inc"
  #include "tcg/helper-mve.h.inc"
diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c
index 403b345ea3..9914f45b16 100644
--- a/target/arm/tcg/mve_helper.c
+++ b/target/arm/tcg/mve_helper.c
@@ -27,6 +27,11 @@
  #include "tcg/tcg.h"
  #include "fpu/softfloat.h"
+#define HELPER_H "tcg/helper-vfp.h.inc"
+#include "exec/helper-proto.h.inc"
+#include "exec/helper-gen.h.inc"
+#undef  HELPER_H
+

Again, none of the *_helper.c need helper-gen.h.inc, only prototypes.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]