[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting
From: |
Cornelia Huck |
Subject: |
Re: [PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting |
Date: |
Tue, 21 Mar 2023 13:20:23 +0100 |
User-agent: |
Notmuch/0.37 (https://notmuchmail.org) |
On Tue, Mar 21 2023, Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 16 Mar 2023 at 11:41, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> On Thu, 16 Mar 2023 at 11:11, Cornelia Huck <cohuck@redhat.com> wrote:
>> >
>> > On Thu, Mar 16 2023, Peter Maydell <peter.maydell@linaro.org> wrote:
>> >
>> > > The markup for the Arm CPU feature documentation is incorrect,
>> > > and results in the HTML not rendering correctly -- the first
>> > > line of each description is rendered in boldface as if it
>> > > were part of the option name.
>> > >
>> > > Reformat to match the styling used in cpu-models-x86.rst.inc.
>> > >
>> > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1479
>> > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> > > ---
>> > > docs/system/arm/cpu-features.rst | 68 ++++++++++++++------------------
>> > > 1 file changed, 30 insertions(+), 38 deletions(-)
>> >
>> > (...)
>> >
>> > > @@ -217,16 +210,15 @@ TCG VCPU Features
>> > > TCG VCPU features are CPU features that are specific to TCG.
>> > > Below is the list of TCG VCPU features and their descriptions.
>> > >
>> > > - pauth-impdef When ``FEAT_Pauth`` is enabled, either the
>> > > - *impdef* (Implementation Defined) algorithm
>> > > - is enabled or the *architected* QARMA
>> > > algorithm
>> > > - is enabled. By default the impdef algorithm
>> > > - is disabled, and QARMA is enabled.
>> > > +``pauth-impdef``
>> > > + When ``FEAT_Pauth`` is enabled, either the *impdef* (Implementation
>> > > + Defined) algorithm is enabled or the *architected* QARMA algorithm
>> > > + is enabled. By default the impdef algorithm is disabled, and QARMA
>> > > + is enabled.
>> > >
>> > > - The architected QARMA algorithm has good
>> > > - cryptographic properties, but can be quite
>> > > slow
>> > > - to emulate. The impdef algorithm used by
>> > > QEMU
>> > > - is non-cryptographic but significantly
>> > > faster.
>> > > + The architected QARMA algorithm has good ryptographic properties,
>> >
>> > You dropped a 'c' here ----------------------^
>>
>> Well spotted...
>
> There weren't any review comments other than the typo, so I'm going
> to fix that and apply to target-arm.next.
In that case, please also add my
Reviewed-by: Cornelia Huck <cohuck@redhat.com>