|
From: | Richard Henderson |
Subject: | Re: [PATCH 03/13] accel/tcg: Store some tlb flags in CPUTLBEntryFull |
Date: | Sun, 5 Mar 2023 10:20:17 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 |
On 3/3/23 08:45, Peter Maydell wrote:
+ + if (wp_flags & BP_MEM_WRITE) { + write_flags |= TLB_WATCHPOINT; + } + tlb_set_compare(full, &tn, vaddr_page, write_flags, MMU_DATA_STORE, + (prot & PAGE_WRITE) && !(prot & PAGE_WRITE_INV));So in the old code, if PAGE_WRITE_INV then we set up the addr_write field as normal, it just also has the TLB_INVALID_MASK bit set. In the new code we won't do that, we'll set addr_write to -1.
Gah. I must have had some sort of rebase fumble, because I know I fixed this, and the WRITE_INV test should be above, not in the predicate.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |