Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

[Philippe Mathieu-Daudé]

On 28/2/23 22:55, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > On 28/2/23 20:06, Alex Bennée wrote:
> > > To avoid lots of copy and paste lets deal with artefacts in a
> > > template. This way we can filter out most of the pre-binary object and
> > > library files we no longer need as we have the final binaries.
> > > build-system-alpine also saved .git-submodule-status so for
> > > simplicity
> > > we bring that into the template as well.
> > > As an example the build-system-ubuntu artefacts before this patch
> > > where around 1.3 GB, after dropping the object files it comes to 970
> > > MB.
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > > ---
> > >    .gitlab-ci.d/buildtest-template.yml | 16 ++++++
> > >    .gitlab-ci.d/buildtest.yml          | 81 +++++++++++------------------
> > >    2 files changed, 46 insertions(+), 51 deletions(-)
> >
> > This is still kludging the fact that 'make check-qtest' rebuild
> > the world even if QEMU binaries are present. Still an improvement, so
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Is something being missed by:
>
>      # Avoid recompiling by hiding ninja with NINJA=":"
>      - make NINJA=":" $MAKE_CHECK_ARGS
>
> ?

Sorry, I wasn't looking at the correct pipeline.