Re: [PATCH 2/2] target/arm: Check V7VE as well as LPAE in arm_pamax

[Richard Henderson]

On 6/24/22 09:27, Peter Maydell wrote:
> > +    /*
> > +     * In machvirt_init, we call arm_pamax on a cpu that is not fully
> > +     * initialized, so we can't rely on the propagation done in realize.
> > +     */
> > +    if (arm_feature(&cpu->env, ARM_FEATURE_LPAE) ||
> > +        arm_feature(&cpu->env, ARM_FEATURE_V7VE)) {
> >           /* v7 with LPAE */
> >           return 40;
>
> I guess this is expedient, so on that basis
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> but as I mentioned in the gitlab issue it's kind of bogus
> that the virt board is doing stuff to a non-realized CPU object.

My first look suggested that the virt board wasn't even setting all of the cpu properties 
properly, so realization might not help.  I meant to go back again and soend more time, 
but that hasn't happened yet.


r~