Re: [PATCH v2 1/8] aspeed: Set CPU memory property explicitly

[Cédric Le Goater]

On 6/24/22 08:36, Cédric Le Goater wrote:
> On 6/24/22 02:36, Peter Delevoryas wrote:
> > Signed-off-by: Peter Delevoryas <pdel@fb.com>
>
> Please merge this patch with patch 2 in which the "memory" property
> is defined.

Ah no. That's another link. I don't understand where that was done
before.

C.


> Thanks,
>
> C.
>
>
> > ---
> >   hw/arm/aspeed_ast2600.c | 2 ++
> >   hw/arm/aspeed_soc.c     | 2 ++
> >   2 files changed, 4 insertions(+)
> >
> > diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
> > index f70b17d3f9..f950fff070 100644
> > --- a/hw/arm/aspeed_ast2600.c
> > +++ b/hw/arm/aspeed_ast2600.c
> > @@ -294,6 +294,8 @@ static void aspeed_soc_ast2600_realize(DeviceState *dev, 
> > Error **errp)
> >           object_property_set_int(OBJECT(&s->cpu[i]), "cntfrq", 1125000000,
> >                                   &error_abort);
> > +        object_property_set_link(OBJECT(&s->cpu[i]), "memory",
> > +                                 OBJECT(get_system_memory()), &error_abort);
> >           if (!qdev_realize(DEVICE(&s->cpu[i]), NULL, errp)) {
> >               return;
> > diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
> > index f530028874..06e5629800 100644
> > --- a/hw/arm/aspeed_soc.c
> > +++ b/hw/arm/aspeed_soc.c
> > @@ -247,6 +247,8 @@ static void aspeed_soc_realize(DeviceState *dev, Error 
> > **errp)
> >       /* CPU */
> >       for (i = 0; i < sc->num_cpus; i++) {
> > +        object_property_set_link(OBJECT(&s->cpu[i]), "memory",
> > +                                 OBJECT(get_system_memory()), &error_abort);
> >           if (!qdev_realize(DEVICE(&s->cpu[i]), NULL, errp)) {
> >               return;
> >           }