Re: [PATCH v5] tests/qtest: add qtests for npcm7xx sdhci

[Hao Wu]

Hi,

We did some experiments on this issue. It looks like the image size restriction is in firmware. So in qtest we can make it

much smaller (e.g. 1MB) and the test still passes. We can send a patch with this change if necessary.

On Thu, May 26, 2022 at 9:21 AM Patrick Venture <venture@google.com> wrote:

On Thu, May 26, 2022 at 8:54 AM Peter Maydell <peter.maydell@linaro.org> wrote:

On Fri, 25 Feb 2022 at 17:45, Hao Wu <wuhaotsh@google.com> wrote:
>
> From: Shengtan Mao <stmao@google.com>
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Chris Rauer <crauer@google.com>
> Signed-off-by: Shengtan Mao <stmao@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>

Hi; John Snow tells me that this test fails in the tests/vm/netbsd
VM (you can test this with 'make vm-build-netbsd') because the
assert() on the ftruncate() call fails:

> +    ret = ftruncate(fd, NPCM7XX_TEST_IMAGE_SIZE);
> +    g_assert_cmpint(ret, ==, 0);

> +#define NPCM7XX_TEST_IMAGE_SIZE (1 << 30)

I haven't investigated the exact cause, but this is a
gigabyte, right? That's a pretty massive file for a test case to
create -- can we make the test use a more sensible size of
sd card image ?

It looks like the nuvoton part had an issue with a smaller image size, but we can resurrect that thread and poke at it a bit and see what shakes out.

 

thanks
-- PMM