Re: [PATCH v2 24/25] target/arm: Rearrange Secure PL1 test in arm_debug_target_el

[Richard Henderson]

On 6/9/22 09:53, Peter Maydell wrote:
> On Tue, 7 Jun 2022 at 04:06, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > Not a bug, because arm_is_el2_enabled tests for secure,
> > and SCR_EL3.EEL2 cannot be set for AArch32, however the
> > ordering of the tests looks odd.  Mirror the structure
> > over in exception_target_el().
>
> I think the code is following the ordering in the
> DebugTarget() and DebugTargetFrom() pseudocode (or else some other
> equivalent function in an older version of the Arm ARM...)

Fair enough.

> I think you're also relying on there being no secure EL2
> if EL3 is AArch32 (otherwise an exception from secure EL0
> might need to be routed to secure EL2, not EL3).

Correct, though I don't imagine SEL2 will ever apply to A32.

I'll drop the patch though.


r~