qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags


From: Richard Henderson
Subject: Re: [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags
Date: Mon, 6 Jun 2022 09:50:37 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 6/6/22 08:58, Peter Maydell wrote:
+        if (FIELD_EX64(env->svcr, SVCR, SM)) {
+            DP_TBFLAG_A64(flags, PSTATE_SM, 1);
+        }
+        DP_TBFLAG_A64(flags, PSTATE_ZA, FIELD_EX64(env->svcr, SVCR, ZA));

Why did you write these two differently? Don't they do the same
thing (set the tb flag to the value of the bit in env->svcr) ?

A later patch adds to the IF.

r~


Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]