[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup
From: |
Peter Maydell |
Subject: |
Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup |
Date: |
Mon, 29 Nov 2021 20:48:08 +0000 |
On Mon, 29 Nov 2021 at 20:05, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> qemu-common.h has a comment at the top:
>
> * This file is supposed to be included only by .c files. No header file
> should
> * depend on qemu-common.h, as this would easily lead to circular header
> * dependencies.
As a side note, that comment was added back in 2012 when qemu-common.h
was bigger, included other headers, and did some of the work we currently
use osdep.h for. As it stands today qemu-common.h includes no other
files so it isn't a source of possible circular dependencies -- it's
just a grab-bag of miscellaneous prototypes that in an ideal world
would be in more focused individual headers[*]. So there's an argument
for deleting this comment...
[*] A cleanup that would be nice, and I'm about to send out a patchset
that splits out the rtc related functions; but the grab-bag at the
bottom of osdep.h is probably higher priority because that header
gets pulled in by an order of magnitude more C files.
-- PMM
- [PATCH for-7.0 0/4] qemu-common.h include cleanup, Peter Maydell, 2021/11/29
- [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h, Peter Maydell, 2021/11/29
- [PATCH for-7.0 4/4] hw/arm: Don't include qemu-common.h unnecessarily, Peter Maydell, 2021/11/29
- [PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files, Peter Maydell, 2021/11/29
- [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h, Peter Maydell, 2021/11/29
- Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup,
Peter Maydell <=
- Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup, Richard Henderson, 2021/11/30