[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] hw/i386: expose a "smbios-entry-point-type" PC machin
Re: [PATCH v3 3/3] hw/i386: expose a "smbios-entry-point-type" PC machine property
Mon, 22 Nov 2021 10:08:15 +0100
On Tue, Nov 02, 2021 at 07:25:25AM -0400, Michael S. Tsirkin wrote:
> On Tue, Nov 02, 2021 at 09:51:35AM +0100, Philippe Mathieu-Daudé wrote:
> > On 10/26/21 17:11, Eduardo Habkost wrote:
> > > The i440fx and Q35 machine types are both hardcoded to use the
> > > legacy SMBIOS 2.1 (32-bit) entry point. This is a sensible
> > > conservative choice because SeaBIOS only supports SMBIOS 2.1
> > >
> > > EDK2, however, can also support SMBIOS 3.0 (64-bit) entry points,
> > > and QEMU already uses this on the ARM virt machine type.
> > >
> > > This adds a property to allow the choice of SMBIOS entry point
> > > versions For example to opt in to 64-bit SMBIOS entry point:
> > >
> > > $QEMU -machine q35,smbios-entry-point-type=64
> > It would be nice to have a test for this...
> > Otherwise,
> > Reviewed-by: Philippe Mathieu-Daudé <firstname.lastname@example.org>
> Can we update seabios and the switch the default?
seabios support is unfortunately not yet merged upstream.
> Maybe just for q35?
> Or are there more considerations?
It's a guest-visible change, so IMHO we need the runtime switch anyway
so old machine types can continue to use the smbios 2.x entry point.
We'll switch the default at some point for sure, but I don't think
that'll happen for the 6.2 machine type. We are simply too late.