[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/arm/virt: Rename default_bus_bypass_iommu

From: Richard Henderson
Subject: Re: [PATCH v2] hw/arm/virt: Rename default_bus_bypass_iommu
Date: Mon, 1 Nov 2021 13:46:04 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/26/21 5:37 AM, Jean-Philippe Brucker wrote:
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
parameter definitions cannot use underscores, because keyval_dashify()
transforms them to dashes and the parser doesn't find the parameter.

This affects option default_bus_bypass_iommu which was introduced in the
same release:

$ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on
qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not 

Rename the parameter to "default-bus-bypass-iommu". Passing
"default_bus_bypass_iommu" is still valid since the underscore are
transformed automatically.

Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option")
Reviewed-by: Eric Auger<eric.auger@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé<philmd@redhat.com>
Tested-by: Eric Auger<eric.auger@redhat.com>
Signed-off-by: Jean-Philippe Brucker<jean-philippe@linaro.org>
v2: Resending to be merged separately from the equivalent x86 fix,
     already queued by Paolo [2]. No change other than added review tag.

  hw/arm/virt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to target-arm.next.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]