Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translatio

qemu-arm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translatio

From:	Richard Henderson
Subject:	Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation
Date:	Wed, 14 Apr 2021 12:43:04 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/14/21 11:03 AM, Max Filippov wrote:

On Wed, Apr 14, 2021 at 9:51 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote:

On Wed, 2021-04-14 at 16:48 +0200, David Hildenbrand wrote:

Did you double-check the xtensa issue?


Oh, I'm sorry, I completely forgot about that one. I just ran the
test locally, and apparently it fails because of this new assert, so
I'll have to write the 4th patch now. Thanks!


Just curious, what xtensa issue?


Returning from xtensa_tr_translate_insn with tb->size == 0.

Basically, dc->base.pc_next needs to be incremented even for illegalinstructions, preferably by the number of bytes consumed while determining thatthe insn is illegal.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 0/3] accel/tcg: Make sure that tb->size != 0 after translation, Ilya Leoshkevich, 2021/04/14
- [PATCH v3 2/3] target/arm: Make sure that commpage's tb->size != 0, Ilya Leoshkevich, 2021/04/14
- [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Ilya Leoshkevich, 2021/04/14
  - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, David Hildenbrand, 2021/04/14
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Ilya Leoshkevich, 2021/04/14
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Max Filippov, 2021/04/14
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Richard Henderson <=
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Max Filippov, 2021/04/14
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Ilya Leoshkevich, 2021/04/15
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Richard Henderson, 2021/04/15
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Peter Maydell, 2021/04/15
    - Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation, Max Filippov, 2021/04/15
- [PATCH v3 1/3] target/s390x: Fix translation exception on illegal instruction, Ilya Leoshkevich, 2021/04/14
  - Re: [PATCH v3 1/3] target/s390x: Fix translation exception on illegal instruction, David Hildenbrand, 2021/04/14

Prev by Date: Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation
Next by Date: [PATCH v7 0/4] Add support for FEAT_TLBIOS and FEAT_TLBIRANGE
Previous by thread: Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation
Next by thread: Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation
Index(es):
- Date
- Thread