qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/3] target/arm: Add support for FEAT_TLBIRANGE


From: Rebecca Cran
Subject: Re: [PATCH v3 1/3] target/arm: Add support for FEAT_TLBIRANGE
Date: Tue, 16 Mar 2021 09:51:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 3/16/21 9:09 AM, Richard Henderson wrote:
On 3/16/21 12:20 AM, Rebecca Cran wrote:
On 3/10/21 12:24 PM, Richard Henderson wrote:
On 3/9/21 6:29 PM, Rebecca Cran wrote:

+    uint64_t addr = (value & 0xFFFFFFFFFUL) << TARGET_PAGE_BITS;

The manual does not explicitly say, but I'm certain that this should be a signed address, when regime_has_2_ranges().  Otherwise it would be impossible to flush a range of kernel addresses.

I see other functions have

uint64_t pageaddr = sextract(value...);

Would that be sufficient here too, or do we need to check regime_has_2_ranges()?

We need to check the regime.

Thanks. I've just sent out a v4 patch, which I hope is closer to being correct.

--
Rebecca Cran



reply via email to

[Prev in Thread] Current Thread [Next in Thread]