[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/9] hw/display/pl110, pxa2xx_lcd: Tidy up template headers
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH 0/9] hw/display/pl110, pxa2xx_lcd: Tidy up template headers |
|
Date: |
Tue, 9 Mar 2021 11:34:03 +0100 |
On Fri, Mar 05, 2021 at 02:48:11PM +0000, Peter Maydell wrote:
> Ping for review?
Looks all sane from ui point of view.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
I suspect we still have some code duplication here due to each display
device having its own set of line render functions. We should be able
to share them at least for common formats. hw/display/framebuffer.c
looks like a good place for shared helpers.
take care,
Gerd