Re: [PATCH 17/44] hw/misc/iotkit-sysctl: Handle SSE-300 changes to PDCM_PD_*_SENSE registers

[Richard Henderson]

On 2/19/21 6:45 AM, Peter Maydell wrote:
> The sysctl PDCM_PD_*_SENSE registers control various power domains in
> the system and allow the guest to configure which conditions keep a
> power domain awake and what power state to use when the domain is in
> a low power state.  QEMU doesn't model power domains, so for us these
> registers are dummy reads-as-written implementations.
>
> The SSE-300 has a different power domain setup, so the set of
> registers is slightly different:
>
>   Offset   SSE-200               SSE-300
> ---------------------------------------------------
>   0x200    PDCM_PD_SYS_SENSE     PDCM_PD_SYS_SENSE
>   0x204    reserved              PDCM_PD_CPU0_SENSE
>   0x208    reserved              reserved
>   0x20c    PDCM_PD_SRAM0_SENSE   reserved
>   0x210    PDCM_PD_SRAM1_SENSE   reserved
>   0x214    PDCM_PD_SRAM2_SENSE   PDCM_PD_VMR0_SENSE
>   0x218    PDCM_PD_SRAM3_SENSE   PDCM_PD_VMR1_SENSE
>
> Offsets 0x200 and 0x208 are the same for both, so handled in a
> previous commit; here we deal with 0x204, 0x20c, 0x210, 0x214, 0x218.
>
> (We can safely add new lines to the SSE300 vmstate because no board
> uses this device in an SSE300 yet.)
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~