qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/44] hw/misc/iotkit-sysctl: Remove is_sse200 flag


From: Richard Henderson
Subject: Re: [PATCH 06/44] hw/misc/iotkit-sysctl: Remove is_sse200 flag
Date: Thu, 4 Mar 2021 09:13:04 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 2/19/21 6:45 AM, Peter Maydell wrote:
Remove the is_sse200 flag in favour of just directly testing the new
sse_version field.

Since some of these registers exist in the SSE-300 but some do not or
have different behaviour, we expand out the if() statements in the
read and write functions into switch()es, so we have an easy place to
put SSE-300 specific behaviour.

(Until we do add the SSE-300 behaviour, the thing preventing us
reaching the "unreachable" default cases is that armsse.c doesn't
yet pass us an ARMSSE_SSE300 version.)

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  include/hw/misc/iotkit-sysctl.h |   2 -
  hw/misc/iotkit-sysctl.c         | 256 +++++++++++++++++++++++---------
  2 files changed, 187 insertions(+), 71 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~





reply via email to

[Prev in Thread] Current Thread [Next in Thread]