Re: [PATCH 2/2] tests/acceptance: Test ast2600 machine

[Joel Stanley]

On Wed, 3 Mar 2021 at 07:43, Cédric Le Goater <clg@kaod.org> wrote:
>
> On 3/3/21 2:22 AM, Joel Stanley wrote:
> > This tests a Debian multi-soc arm32 Linux kernel on the AST2600 based
> > Tacoma BMC machine.
> >
> > There is no root file system so the test terminates when boot reaches
> > the stage where it attempts and fails to mount something.
>
> because of that, the test always fails  :
>
> console: [    3.615193] No filesystem could mount root, tried:
> console: [    3.615269]
> console: [    3.615688] Kernel panic - not syncing: VFS: Unable to mount root 
> fs on unknown-block(0,0)
> FAIL: Failure message found in console: Kernel panic - not syncing (22.45 s)
> RESULTS    : PASS 0 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | 
> CANCEL 0

You're right. I must have been testing a different setup when I put
these checks in:

> > +        self.wait_for_console_pattern("ftgmac100 1e670000.ftgmac eth0: 
> > irq")
> > +        self.wait_for_console_pattern("VFS: Cannot open root device")

The second string is different to what we see with the kernel we're
booting, and more importantly the first string doesn't ever appear.
This is because the kernel driver is built as a module, and with no
filesystem we don't have any modules to load. IIRC the test is still
waiting on the ftgmac string when it sees the panic, so even if the
VFS string was correct it wouldn't save us.

This will sort it out:

 -        self.wait_for_console_pattern("ftgmac100 1e670000.ftgmac eth0: irq")
 -        self.wait_for_console_pattern("VFS: Cannot open root device")
 +        self.wait_for_console_pattern("No filesystem could mount root")

I'll send a v2. Thanks for testing.

Cheers,

Joel