Re: [PATCH v2 05/24] target/arm: Fix SCTLR_B test for TCGv_i64 load/store

[Richard Henderson]

On 1/7/21 6:00 AM, Peter Maydell wrote:
> On Tue, 8 Dec 2020 at 18:01, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Just because operating on a TCGv_i64 temporary does not
>> mean that we're performing a 64-bit operation.  Restrict
>> the frobbing to actual 64-bit operations.
> 
> If I understand correctly, this patch isn't actually a behaviour
> change because at this point the only users of gen_aa32_ld_i64()
> and gen_aa32_st_i64() are in fact performing 64-bit operations
> so the (opc & MO_SIZE) == MO_64 test is always true.

Correct.

> (Presumably
> subsequent patches are going to add uses of these functions that
> want to load smaller sizes?)

Correct.

> If that's right, worth mentioning
> explicitly in the commit message, I think.

Will do.


r~