Re: [PATCH 06/15] target/arm: Enforce M-profile VMRS/VMSR register restrictions

[Peter Maydell]

On Tue, 17 Nov 2020 at 19:42, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 11/16/20 8:08 AM, Peter Maydell wrote:
> > -        if (a->rt == 15 && (!a->l || a->reg != ARM_VFP_FPSCR)) {
> > +        if (a->reg != ARM_VFP_FPSCR) {
> > +            return false;
> > +        }
> > +        if (a->rt == 15 && !a->l) {
>
> Alternately, the parenthesis are just off:
>
>   if ((a->rt == 15 && !a->l) || a->reg != ARM_VFP_FPSCR)

Mmm. As you've probably discovered by now, the refactoring
in the subsequent patches means that this code gets moved
and changed anyway; I just wanted it in this separate
patch so the bugfix wasn't hidden in the refactoring.

thanks
-- PMM