[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directo
From: |
Peter Maydell |
Subject: |
Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories |
Date: |
Tue, 27 Oct 2020 21:20:39 +0000 |
On Mon, 26 Oct 2020 at 21:29, Keith Packard <keithp@keithp.com> wrote:
>
> This commit renames two files which provide ARM semihosting support so
> that they can be shared by other architectures:
>
> 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
> 2. linux-user/arm/semihost.c -> linux-user/semihost.c
>
> The build system was modified to reflect this change, but the contents
> of the two files are unchanged.
>
> Signed-off-by: Keith Packard <keithp@keithp.com>
> ---
> diff --git a/target/arm/arm-semi.c b/hw/semihosting/common-semi.c
> similarity index 100%
> rename from target/arm/arm-semi.c
> rename to hw/semihosting/common-semi.c
> diff --git a/hw/semihosting/meson.build b/hw/semihosting/meson.build
> index f40ac574c4..fbd2841e59 100644
> --- a/hw/semihosting/meson.build
> +++ b/hw/semihosting/meson.build
> @@ -2,3 +2,5 @@ specific_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files(
> 'config.c',
> 'console.c',
> ))
> +
> +specific_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
I think this adds this file to the compilation for all TCG targets;
you only want it for targets which have Arm-semihosting-ABI compatible
semihosting. (Various other targets either don't have semihosting
or have their own ABI.)
thanks
-- PMM
[PATCH 2/4] semihosting: Change common-semi API to be architecture-independent, Keith Packard, 2020/10/26
[PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *, Keith Packard, 2020/10/26
[PATCH 4/4] riscv: Add semihosting support [v10], Keith Packard, 2020/10/26
Re: [PATCH 0/4] riscv: Add semihosting support [v10], no-reply, 2020/10/26