[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/9] tcg: add const hints for code pointers
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 5/9] tcg: add const hints for code pointers |
|
Date: |
Mon, 19 Oct 2020 16:19:22 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 10/18/20 6:39 PM, Joelle van Dyne wrote:
> From: osy <osy86@users.noreply.github.com>
>
> We will introduce mirror mapping for JIT segment with separate RX and RW
> access. Adding 'const' hints will make it easier to identify read-only
> accesses and allow us to easier catch bugs at compile time in the future.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
Are you "osy"? We do need S-o-b with real names from all contributors to the
patch.
The patch is bigger than I would like, but it all appears to be strongly
connected, and I don't see where it could be split. I'm inclined to
cherry-pick this patch out now to avoid carrying it around. So if I can either
fix the --author to you, or we can get a s-o-b from the author, I'll do that.
r~