Re: [PATCH v2 3/5] hw/pci-host/versatile: Add the MEMORY_WINDOW_COUNT definition

[Peter Maydell]

On Mon, 12 Oct 2020 at 14:20, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Note from Peter Maydell:
>
>  The versatile/realview PCI controller has:
>    * three memory windows in the system address space
>      - those are represented by the pci_mem_window[] array
>      - mem_win_size[] holds the size of each window
>        (which is fixed but varies between the different
>        implementations of this controller on different boards)
>      - the device IMAPn registers allow the guest to
>        configure the mapping from "a CPU access to an
>        address in window n" to "a PCI address on the PCI bus,
>        and our imap[] array holds those register values
>
> Use self-explicit MEMORY_WINDOW_COUNT definition instead of
> a magic value.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM