[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

From: Richard Henderson
Subject: Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig
Date: Sat, 3 Oct 2020 04:32:37 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 10/3/20 4:15 AM, Paolo Bonzini wrote:
> On 03/10/20 11:13, Richard Henderson wrote:
>>> +    target_kconfig = 'target' / config_target['TARGET_BASE_ARCH'] / 
>>> 'Kconfig'
>>> +    minikconf_input = ['default-configs' / target + '.mak', 'Kconfig']
>>> +    if fs.is_file(target_kconfig)
>> Missing a meson.current_source_dir()?
>> Leastwise that was a comment that Paolo had for me.
> Not sure, but it was the only way I thought the BSD build could fail;
> unless the capstone submodule really was not present in Peter's checkout
> and submodule update was disabled.

I don't think the build actually failed, I think it was just the cmake warning
from the missing method: to which Peter objected.

FWIW with and without source_dir work for me when testing, and I'm about to
include it in the v3 pull for an abundance of caution.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]