[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel

From: Thomas Huth
Subject: Re: [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel
Date: Sat, 3 Oct 2020 11:17:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 30/09/2020 10.03, Philippe Mathieu-Daudé wrote:
On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote:
KVM requires a cpu based on (at least) the ARMv7 architecture.

Only enable the following ARMv4 CPUs when TCG is available:

   - StrongARM (SA1100/1110)
   - OMAP1510 (TI925T)

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
  hw/arm/Kconfig | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 7d040827af..b546b20654 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -1,3 +1,7 @@
+config ARM_V4
+    bool
+    select TCG

This should be 'depends on TCG' because we can not
*select* TCG, either we enabled it or not.

The problem is the machines are already selected in
default-configs/arm-softmmu.mak, so we can not build
the current config without TCG.

Is it really a problem? If the users disabled TCG and still have these machines in their arm-softmmu.mak, it's a configuration issue on their side, so it's ok if they get an error in that case.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]