Re: [PATCH v1 0/2] pc-bios: petalogix: Re-generate DTB and add DTS files

[Edgar E. Iglesias]

On Fri, Aug 21, 2020 at 01:02:59PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Edgar,
> 
> On 8/20/20 9:43 PM, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > 
> > This adds missing device-tree source files for the petalogix boards
> > with recompiled DTBs.
> > 
> > Cheers,
> > Edgar
> > 
> > Edgar E. Iglesias (2):
> >   microblaze: petalogix-ml605: Add device-tree source
> >   microblaze: petalogix-s3adsp1800: Add device-tree source
> > 
> >  pc-bios/petalogix-ml605.dtb      | Bin 9982 -> 9882 bytes
> >  pc-bios/petalogix-ml605.dts      | 350 +++++++++++++++++++++++++++++++
> >  pc-bios/petalogix-s3adsp1800.dtb | Bin 8259 -> 8161 bytes
> >  pc-bios/petalogix-s3adsp1800.dts | 282 +++++++++++++++++++++++++
> >  4 files changed, 632 insertions(+)
> >  create mode 100644 pc-bios/petalogix-ml605.dts
> >  create mode 100644 pc-bios/petalogix-s3adsp1800.dts
> > 
> 
> I suppose the test_microblaze_s3adsp1800() test in
> tests/acceptance/boot_linux_console.py has the dtb embedded after the
> kernel.

Not sure, but I'll see if I can figure it out.

> 
> Do you mind adding another test explicitly using this dtb?
> That would cover any further changes in these files.

Sounds like a good idea!

Thanks,
Edgar

> 
> Also, can you add a test for the kc705 EVB (and previous)
> boards as you suggested here?
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg605124.html
> 
> I already added a test for the cris/etraxfs board, will send
> it soon. Well you might wait for it and use it as template too.
> 
> Anyway,
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>