Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc"

[sundeep subbaraya]

On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>
> > On 7/15/20 4:04 PM, Markus Armbruster wrote:
> >> Watch this:
> >>
> >>     $ qemu-system-aarch64 -M ast2600-evb -S -display none -qmp stdio
> >>     {"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 5}, 
> >> "package": "v5.0.0-2464-g3a9163af4e"}, "capabilities": ["oob"]}}
> >>     {"execute": "qmp_capabilities"}
> >>     {"return": {}}
> >>     {"execute": "device-list-properties", "arguments": {"typename": 
> >> "msf2-soc"}}
> >>     Unsupported NIC model: ftgmac100
> >>     armbru@dusky:~/work/images$ echo $?
> >>     1
> >>
> >> This is what breaks "make check SPEED=slow".
> >>
> >> Root cause is m2sxxx_soc_initfn()'s messing with nd_table[] via
> >> qemu_check_nic_model().  That's wrong.
> >>
> >> We fixed the exact same bug for device "allwinner-a10" in commit
> >> 8aabc5437b "hw/arm/allwinner-a10: Do not use nd_table in instance_init
> >> function".  Fix this instance the same way: move the offending code to
> >> m2sxxx_soc_realize(), where it's less wrong, and add a FIXME comment.
> >
> > That addresses this other thread, right?
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg720658.html
>
> Correct!  I wasn't aware of it, thanks for making the connection.
>

Thanks Markus for the fix.
Sundeep