[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ftgmac100: fix dblac write test

From: Jason Wang
Subject: Re: [PATCH v2] ftgmac100: fix dblac write test
Date: Tue, 14 Jul 2020 17:04:02 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 2020/7/13 下午8:06, Cédric Le Goater wrote:
On 7/7/20 9:42 AM, Erik Smit wrote:
Hi Andrew,

On Mon, 6 Jul 2020 at 03:59, Andrew Jeffery <andrew@aj.id.au> wrote:
On Sun, 28 Jun 2020, at 23:56, erik-smit wrote:
The test of the write of the dblac register was testing the old value
instead of the new value. This would accept the write of an invalid value
but subsequently refuse any following valid writes.

Signed-off-by: erik-smit <erik.lucas.smit@gmail.com>
Changes since v1:

Changed %ld to HWADDR_PRIx to fix building on mingw
Bit of a nitpick, but the type of the value argument is uint64_t, so shouldn't
the result of the expression captured by FTGMAC100_DBLAC_TXDES_SIZE() and
FTGMAC100_DBLAC_RXDES_SIZE() be printed with a straight PRIx64 rather than
You are correct. I didn't understand the meaning of the PRI macros and
just grabbed the other PRI macro I saw getting used in the file.
With that fixed,

Reviewed-by: Cédric Le Goater <clg@kaod.org>



Applied by switching to use PRIx64.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]