[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] migration: Count new_dirty instead of real_dirty

From: zhukeqian
Subject: Re: [PATCH v3] migration: Count new_dirty instead of real_dirty
Date: Mon, 6 Jul 2020 19:53:37 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1

Hi Dave,

On 2020/7/3 22:20, Dr. David Alan Gilbert wrote:
> * Keqian Zhu (zhukeqian1@huawei.com) wrote:
>> real_dirty_pages becomes equal to total ram size after dirty log sync
>> in ram_init_bitmaps, the reason is that the bitmap of ramblock is
>> initialized to be all set, so old path counts them as "real dirty" at
>> beginning.
>> This causes wrong dirty rate and false positive throttling.
>> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> OK, 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> and queued.
> you might still want to look at migration_trigger_thrtottle and see if
> you can stop the throttling if in the RAM bulk stage.
Yes, I tested it and it worked well.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]