[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] ftgmac100: fix dblac write test
From: |
Andrew Jeffery |
Subject: |
Re: [PATCH v2] ftgmac100: fix dblac write test |
Date: |
Mon, 06 Jul 2020 11:29:24 +0930 |
User-agent: |
Cyrus-JMAP/3.3.0-dev0-576-gfe2cd66-fm-20200629.001-gfe2cd668 |
On Sun, 28 Jun 2020, at 23:56, erik-smit wrote:
> The test of the write of the dblac register was testing the old value
> instead of the new value. This would accept the write of an invalid value
> but subsequently refuse any following valid writes.
>
> Signed-off-by: erik-smit <erik.lucas.smit@gmail.com>
> ---
> Changes since v1:
>
> Changed %ld to HWADDR_PRIx to fix building on mingw
Bit of a nitpick, but the type of the value argument is uint64_t, so shouldn't
the result of the expression captured by FTGMAC100_DBLAC_TXDES_SIZE() and
FTGMAC100_DBLAC_RXDES_SIZE() be printed with a straight PRIx64 rather than
HWADDR_PRIx?
Otherwise the change seems sensible, so:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
- Re: [PATCH v2] ftgmac100: fix dblac write test,
Andrew Jeffery <=