Re: [PATCH v4 00/21] microvm: add acpi support

[no-reply]

Patchew URL: 20200702204859.9876-1-kraxel@redhat.com/">https://patchew.org/QEMU/20200702204859.9876-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v4 00/21] microvm: add acpi support
Type: series
Message-id: 20200702204859.9876-1-kraxel@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200702204859.9876-1-kraxel@redhat.com -> 
patchew/20200702204859.9876-1-kraxel@redhat.com
Switched to a new branch 'test'
6d5eb94 tests/acpi: update expected data files for microvm
bc45791 tests/acpi: add microvm test
c4b1e12 tests/acpi: allow override blkdev
afb44f2 tests/acpi: allow microvm test data updates.
ef356bd tests/acpi: clear bios-tables-test-allowed-diff.h
b80aa70 microvm: wire up hotplug
8f80d76 x86: move cpu plug from pc to x86
e3d689d x86: move acpi_dev from pc/microvm
2ca513e x86: constify x86_machine_is_*_enabled
dff3286 microvm/acpi: disable virtio-mmio cmdline hack
ee2b30f microvm/acpi: use seabios with acpi=on
ec0fefa microvm/acpi: use GSI 16-23 for virtio
35a5595 microvm/acpi: add acpi_dsdt_add_virtio() for x86
ef52f38 microvm/acpi: add minimal acpi support
9c5c1a3 microvm: make virtio irq base runtime configurable
dfbba95 acpi: move acpi_dsdt_add_power_button() to ged
9350314 acpi: ged: add x86 device variant.
7e7cbaa acpi: ged: add control regs
0d6d2dd seabios: add bios-microvm.bin binary
f847401 seabios: add microvm config, update build rules
1aa4e76 microvm: name qboot binary qboot.rom

=== OUTPUT BEGIN ===
1/21 Checking commit 1aa4e767856e (microvm: name qboot binary qboot.rom)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
rename from pc-bios/bios-microvm.bin

total: 0 errors, 1 warnings, 35 lines checked

Patch 1/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/21 Checking commit f84740183b7c (seabios: add microvm config, update build 
rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 39 lines checked

Patch 2/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/21 Checking commit 0d6d2ddc3815 (seabios: add bios-microvm.bin binary)
4/21 Checking commit 7e7cbaa1cf2a (acpi: ged: add control regs)
5/21 Checking commit 9350314a8c62 (acpi: ged: add x86 device variant.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 51 lines checked

Patch 5/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit dfbba956d1bc (acpi: move acpi_dsdt_add_power_button() to 
ged)
7/21 Checking commit 9c5c1a34efc7 (microvm: make virtio irq base runtime 
configurable)
8/21 Checking commit ef52f38efb11 (microvm/acpi: add minimal acpi support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#39: FILE: hw/i386/acpi-microvm.c:1:
+/* Support for generating ACPI tables and passing them to Guests

WARNING: Block comments use a leading /* on a separate line
#150: FILE: hw/i386/acpi-microvm.c:112:
+    table_offsets = g_array_new(false, true /* clear */,

WARNING: Block comments use a leading /* on a separate line
#154: FILE: hw/i386/acpi-microvm.c:116:
+                             64 /* Ensure FACS is aligned */,

WARNING: Block comments use a leading /* on a separate line
#155: FILE: hw/i386/acpi-microvm.c:117:
+                             false /* high memory */);

total: 0 errors, 5 warnings, 297 lines checked

Patch 8/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/21 Checking commit 35a55956c365 (microvm/acpi: add acpi_dsdt_add_virtio() for 
x86)
10/21 Checking commit ec0fefa9351d (microvm/acpi: use GSI 16-23 for virtio)
11/21 Checking commit ee2b30f1d829 (microvm/acpi: use seabios with acpi=on)
12/21 Checking commit dff3286bf4a4 (microvm/acpi: disable virtio-mmio cmdline 
hack)
13/21 Checking commit 2ca513ea5407 (x86: constify x86_machine_is_*_enabled)
14/21 Checking commit e3d689d93ee0 (x86: move acpi_dev from pc/microvm)
15/21 Checking commit 8f80d768dea4 (x86: move cpu plug from pc to x86)
ERROR: space required before the open parenthesis '('
#344: FILE: hw/i386/x86.c:187:
+    if(!object_dynamic_cast(OBJECT(cpu), ms->cpu_type)) {

WARNING: Block comments use a leading /* on a separate line
#431: FILE: hw/i386/x86.c:274:
+    /* if 'address' properties socket-id/core-id/thread-id are not set, set 
them

WARNING: Block comments use a leading /* on a separate line
#434: FILE: hw/i386/x86.c:277:
+    /* TODO: move socket_id/core_id/thread_id checks into x86_cpu_realizefn()

WARNING: Block comments use a trailing */ on a separate line
#436: FILE: hw/i386/x86.c:279:
+     * CPUState::nr_cores and CPUState::nr_threads fields instead of globals */

WARNING: Block comments use a leading /* on a separate line
#484: FILE: hw/i386/x86.c:327:
+        /* If the number of CPUs can't be represented in 8 bits, the

WARNING: Block comments use a leading /* on a separate line
#502: FILE: hw/i386/x86.c:345:
+/* returns pointer to CPUArchId descriptor that matches CPU's apic_id

total: 1 errors, 5 warnings, 533 lines checked

Patch 15/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/21 Checking commit b80aa70e374f (microvm: wire up hotplug)
17/21 Checking commit ef356bd1fb47 (tests/acpi: clear 
bios-tables-test-allowed-diff.h)
18/21 Checking commit afb44f2d850b (tests/acpi: allow microvm test data 
updates.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 4 lines checked

Patch 18/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/21 Checking commit c4b1e125fc0e (tests/acpi: allow override blkdev)
20/21 Checking commit bc457914cb9c (tests/acpi: add microvm test)
21/21 Checking commit 6d5eb9469a97 (tests/acpi: update expected data files for 
microvm)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200702204859.9876-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200702204859.9876-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com