Re: [PATCH v4] arm/virt: Add memory hot remove support

[Peter Maydell]

On Wed, 24 Jun 2020 at 17:50, Shameerali Kolothum Thodi
<shameerali.kolothum.thodi@huawei.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Igor Mammedov [mailto:imammedo@redhat.com]
> > doesn't pc_dimm_unplug() do unrealize already?
> > (/me wonders why it doesn't explode here,
> > are we leaking a refference somewhere so dimm is still alive?)
>
> Does it? From a quick look at the code it is not obvious.
>
> pc_dimm_unplug()
>   memory_device_unplug()
>     memory_region_del_subregion()
>   vmstate_unregister_ram()
>     qemu_ram_unset_idstr()
>     qemu_ram_unset_migratable()
>
> If it does, then we may need to fix x86/ppc as well.

In any case this patch is now in master, so if you determine
that it needs a fix please send that as a followup patch.

thanks
-- PMM