[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/11] io_uring: retry io_uring_submit() if it fails with errno=EI
From: |
Stefan Hajnoczi |
Subject: |
[PULL 01/11] io_uring: retry io_uring_submit() if it fails with errno=EINTR |
Date: |
Fri, 5 Jun 2020 10:47:40 +0100 |
From: Stefano Garzarella <sgarzare@redhat.com>
As recently documented [1], io_uring_enter(2) syscall can return an
error (errno=EINTR) if the operation was interrupted by a delivery
of a signal before it could complete.
This should happen when IORING_ENTER_GETEVENTS flag is used, for
example during io_uring_submit_and_wait() or during io_uring_submit()
when IORING_SETUP_IOPOLL is enabled.
We shouldn't have this problem for now, but it's better to prevent it.
[1]
https://github.com/axboe/liburing/commit/344355ec6619de8f4e64584c9736530b5346e4f4
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20200519133041.112138-1-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/io_uring.c b/block/io_uring.c
index a3142ca989..9765681f7c 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -231,7 +231,7 @@ static int ioq_submit(LuringState *s)
trace_luring_io_uring_submit(s, ret);
/* Prevent infinite loop if submission is refused */
if (ret <= 0) {
- if (ret == -EAGAIN) {
+ if (ret == -EAGAIN || ret == -EINTR) {
continue;
}
break;
--
2.25.4
- [PULL 00/11] Block patches, Stefan Hajnoczi, 2020/06/05
- [PULL 01/11] io_uring: retry io_uring_submit() if it fails with errno=EINTR,
Stefan Hajnoczi <=
- [PULL 02/11] io_uring: use io_uring_cq_ready() to check for ready cqes, Stefan Hajnoczi, 2020/06/05
- [PULL 03/11] fuzz: add datadir for oss-fuzz compatability, Stefan Hajnoczi, 2020/06/05
- [PULL 04/11] fuzz: fix typo in i440fx-qtest-reboot arguments, Stefan Hajnoczi, 2020/06/05
- [PULL 05/11] fuzz: add mangled object name to linker script, Stefan Hajnoczi, 2020/06/05
- [PULL 06/11] fuzz: run the main-loop in fork-server process, Stefan Hajnoczi, 2020/06/05
- [PULL 08/11] memory: Extract memory_region_msync() from memory_region_writeback(), Stefan Hajnoczi, 2020/06/05
- [PULL 07/11] memory: Rename memory_region_do_writeback -> memory_region_writeback, Stefan Hajnoczi, 2020/06/05
- [PULL 09/11] hw/block: Let the NVMe emulated device be target-agnostic, Stefan Hajnoczi, 2020/06/05
- [PULL 10/11] exec: Rename qemu_ram_writeback() as qemu_ram_msync(), Stefan Hajnoczi, 2020/06/05
- [PULL 11/11] block: Factor out bdrv_run_co(), Stefan Hajnoczi, 2020/06/05