Re: [PATCH v3 22/22] [RfC] acpi: flip default to off for microvm

[Igor Mammedov]

On Wed, 20 May 2020 15:20:03 +0200
Gerd Hoffmann <address@hidden> wrote:

> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/i386/microvm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index 602c6a8f75f3..b5c445b5403b 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -517,6 +517,7 @@ static void microvm_machine_initfn(Object *obj)
>  static void microvm_class_init(ObjectClass *oc, void *data)
>  {
>      MachineClass *mc = MACHINE_CLASS(oc);
> +    X86MachineClass *x86mc = X86_MACHINE_CLASS(oc);
>  
>      mc->init = microvm_machine_state_init;
>  
> @@ -537,6 +538,9 @@ static void microvm_class_init(ObjectClass *oc, void 
> *data)
>      /* Machine class handlers */
>      mc->reset = microvm_machine_reset;
>  
> +    /* acpi is off by default */
> +    x86mc->acpi_default = false;

Since we don't care about compat stuff for microvm yet,
I'd preffer default 'on', as in long run it allows to boot larger range of 
guests
without need for tuning QEMU and guest configuration
(i.e. it's the least troublesome case for ordinary user)

> +
>      object_class_property_add(oc, MICROVM_MACHINE_PIC, "OnOffAuto",
>                                microvm_machine_get_pic,
>                                microvm_machine_set_pic,