[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated d
From: |
Beata Michalska |
Subject: |
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic |
Date: |
Fri, 8 May 2020 16:20:35 +0100 |
On Fri, 8 May 2020 at 07:33, Paolo Bonzini <address@hidden> wrote:
>
> On 08/05/20 08:24, Philippe Mathieu-Daudé wrote:
> > It is not clear if dccvap_writefn() really needs
> > memory_region_writeback() or could use memory_region_msync().
>
> Indeed, I don't understand the code and why it matters that
> mr->dirty_log_mask is nonzero.
>
> mr->dirty_log_mask tells if dirty tracking has been enabled, not if the
> page is dirty. It would always be true during live migration and when
> running on TCG, but otherwise it would always be false.
>
> Beata, can you explain what you had in mind? :)
>
It has been a while ... , but the intention there was to skip the sync
if there is nothing to be synced in the first place - so for performance
reasons. I honestly do not recall why I went for the dirty_log_mask,
as that seems not to be the right choice .
BR
Beata
> Paolo
>
- [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback, Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 2/4] memory: Extract memory_region_msync() from memory_region_writeback(), Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 3/4] hw/block: Let the NVMe emulated device be target-agnostic, Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync(), Philippe Mathieu-Daudé, 2020/05/08
- Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Paolo Bonzini, 2020/05/08
- Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic,
Beata Michalska <=
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Stefan Hajnoczi, 2020/05/21
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Stefan Hajnoczi, 2020/05/27