Re: [Qemu devel PATCH v4 3/3] tests/boot_linux_console: Add ethernet test to SmartFusion2

[sundeep subbaraya]

Hi Philippe,

On Sun, Apr 12, 2020 at 11:32 PM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> On 4/10/20 4:45 PM, address@hidden wrote:
> > From: Subbaraya Sundeep <address@hidden>
> >
> > In addition to simple serial test this patch uses ping
> > to test the ethernet block modelled in SmartFusion2 SoC.
> >
> > Signed-off-by: Subbaraya Sundeep <address@hidden>
> > ---
> >  tests/acceptance/boot_linux_console.py | 15 ++++++++++-----
> >  1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/acceptance/boot_linux_console.py 
> > b/tests/acceptance/boot_linux_console.py
> > index f825cd9..c6b06a1 100644
> > --- a/tests/acceptance/boot_linux_console.py
> > +++ b/tests/acceptance/boot_linux_console.py
> > @@ -336,13 +336,13 @@ class BootLinuxConsole(Test):
> >          """
> >          uboot_url = ('https://raw.githubusercontent.com/'
> >                       'Subbaraya-Sundeep/qemu-test-binaries/'
> > -                     'fa030bd77a014a0b8e360d3b7011df89283a2f0b/u-boot')
> > -        uboot_hash = 'abba5d9c24cdd2d49cdc2a8aa92976cf20737eff'
> > +                     'fe371d32e50ca682391e1e70ab98c2942aeffb01/u-boot')
> > +        uboot_hash = 'cbb8cbab970f594bf6523b9855be209c08374ae2'
> >          uboot_path = self.fetch_asset(uboot_url, asset_hash=uboot_hash)
> >          spi_url = ('https://raw.githubusercontent.com/'
> >                     'Subbaraya-Sundeep/qemu-test-binaries/'
> > -                   'fa030bd77a014a0b8e360d3b7011df89283a2f0b/spi.bin')
> > -        spi_hash = '85f698329d38de63aea6e884a86fbde70890a78a'
> > +                   'fe371d32e50ca682391e1e70ab98c2942aeffb01/spi.bin')
> > +        spi_hash = '65523a1835949b6f4553be96dec1b6a38fb05501'
> >          spi_path = self.fetch_asset(spi_url, asset_hash=spi_hash)
> >
> >          self.vm.set_console()
> > @@ -352,7 +352,12 @@ class BootLinuxConsole(Test):
> >                           '-drive', 'file=' + spi_path + 
> > ',if=mtd,format=raw',
> >                           '-no-reboot')
> >          self.vm.launch()
> > -        self.wait_for_console_pattern('init started: BusyBox')
> > +        self.wait_for_console_pattern('Enter \'help\' for a list')
> > +
> > +        exec_command_and_wait_for_pattern(self, 'ifconfig eth0 10.0.2.15',
> > +                                                 'eth0: link becomes 
> > ready')
> > +        exec_command_and_wait_for_pattern(self, 'ping -c 3 10.0.2.2',
> > +            '3 packets transmitted, 3 packets received, 0% packet loss')
>
> Very nice (and smart) :)
>

Thank you :)
Sundeep

> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> >
> >      def do_test_arm_raspi2(self, uart_id):
> >          """
> >