qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.1 v2 49/54] various: Use &error_abort in instance_init(


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-5.1 v2 49/54] various: Use &error_abort in instance_init()
Date: Mon, 6 Apr 2020 20:19:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
Patch created mechanically by running:

   $ spatch \
     --macro-file scripts/cocci-macro-file.h \
     --include-headers --keep-comments --in-place \
     --sp-file \
       scripts/coccinelle/use-error_abort-in-instance_init.cocci

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
  backends/cryptodev-vhost-user.c |  2 +-
  backends/rng-egd.c              |  2 +-
  backends/rng-random.c           |  2 +-
  backends/vhost-user.c           |  3 ++-
  hw/arm/bcm2835_peripherals.c    |  6 ++++--
  hw/arm/vexpress.c               |  8 ++++----
  hw/arm/xlnx-zcu102.c            |  8 ++++----
  hw/block/fdc.c                  |  4 ++--
  hw/block/vhost-user-blk.c       |  2 +-
  hw/block/virtio-blk.c           |  2 +-
  hw/core/machine.c               |  6 +++---
  hw/cpu/core.c                   |  4 ++--
  hw/display/vga-pci.c            |  7 +++++--
  hw/display/xlnx_dp.c            |  4 ++--
  hw/dma/sparc32_dma.c            |  2 +-
  hw/gpio/aspeed_gpio.c           |  2 +-
  hw/ide/macio.c                  |  4 +++-
  hw/ide/qdev.c                   |  4 ++--
  hw/intc/apic_common.c           |  2 +-
  hw/mem/nvdimm.c                 |  4 ++--
  hw/misc/aspeed_sdmc.c           |  2 +-
  hw/misc/edu.c                   |  3 ++-
  hw/misc/macio/macio.c           |  4 ++--
  hw/misc/macio/pmu.c             |  3 ++-
  hw/misc/pca9552.c               |  2 +-
  hw/misc/tmp105.c                |  2 +-
  hw/misc/tmp421.c                |  8 ++++----
  hw/net/e1000.c                  |  3 ++-
  hw/net/lance.c                  |  3 ++-
  hw/net/lasi_i82596.c            |  3 ++-
  hw/net/ne2000-isa.c             |  4 ++--
  hw/net/spapr_llan.c             |  2 +-
  hw/net/virtio-net.c             |  2 +-
  hw/pci-host/grackle.c           |  2 +-
  hw/pci-host/i440fx.c            |  8 ++++----
  hw/pci-host/prep.c              |  2 +-
  hw/pci-host/q35.c               | 23 ++++++++++++++---------
  hw/pci-host/sabre.c             |  3 ++-
  hw/pci-host/uninorth.c          |  9 +++++----
  hw/pcmcia/pxa2xx.c              |  3 ++-
  hw/ppc/spapr_drc.c              |  6 +++---
  hw/ppc/spapr_rng.c              |  2 +-
  hw/riscv/sifive_u.c             |  4 ++--
  hw/s390x/event-facility.c       |  6 +++---
  hw/s390x/s390-ccw.c             |  2 +-
  hw/s390x/s390-skeys.c           |  4 ++--
  hw/s390x/s390-stattrib.c        |  4 ++--
  hw/s390x/sclp.c                 |  2 +-
  hw/scsi/scsi-bus.c              |  2 +-
  hw/ssi/xilinx_spips.c           |  2 +-
  hw/usb/bus.c                    |  4 ++--
  hw/usb/dev-network.c            |  2 +-
  hw/usb/dev-storage.c            |  4 ++--
  hw/usb/host-libusb.c            |  2 +-
  hw/usb/redirect.c               |  2 +-
  hw/virtio/virtio-balloon.c      |  4 ++--
  net/dump.c                      |  4 ++--
  net/filter-buffer.c             |  2 +-
  net/filter-mirror.c             | 10 +++++-----
  net/filter-rewriter.c           |  3 ++-
  target/arm/cpu64.c              |  4 ++--
  target/i386/cpu.c               | 23 ++++++++++++++---------
  target/s390x/cpu.c              |  3 ++-
  tests/check-qom-proplist.c      |  7 ++++---
  tests/test-qdev-global-props.c  |  4 ++--
  65 files changed, 155 insertions(+), 126 deletions(-)

[...]
diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c
index 270c690479..09315f412c 100644
--- a/tests/test-qdev-global-props.c
+++ b/tests/test-qdev-global-props.c

Oops I forgot to commit this hunk:

@@ -27,6 +27,7 @@
 #include "hw/qdev-properties.h"
 #include "qom/object.h"
 #include "qapi/visitor.h"
+#include "qapi/error.h"


 #define TYPE_STATIC_PROPS "static_prop_type"

@@ -151,9 +151,9 @@ static void prop2_accessor(Object *obj, Visitor *v, const 
char *name,
  static void dynamic_instance_init(Object *obj)
  {
      object_property_add(obj, "prop1", "uint32", prop1_accessor, 
prop1_accessor,
-                        NULL, NULL, NULL);
+                        NULL, NULL, &error_abort);
      object_property_add(obj, "prop2", "uint32", prop2_accessor, 
prop2_accessor,
-                        NULL, NULL, NULL);
+                        NULL, NULL, &error_abort);
  }
static void dynamic_class_init(ObjectClass *oc, void *data)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]