[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when calculating row mirror address |
Date: |
Thu, 26 Mar 2020 21:01:18 +0000 |
On Mon, 23 Mar 2020 at 19:29, Niek Linnenbank <address@hidden> wrote:
>
> The allwinner_h3_dramc_map_rows function simulates row addressing behavior
> when bootloader software attempts to detect the amount of available SDRAM.
>
> Currently the line that calculates the 64-bit address of the mirrored row
> uses a signed 32-bit multiply operation that in theory could result in the
> upper 32-bit be all 1s. This commit ensures that the row mirror address
> is calculated using only 64-bit operations.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Niek Linnenbank <address@hidden>
> ---
> hw/misc/allwinner-h3-dramc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to target-arm.next, thanks.
-- PMM