[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel |
Date: |
Mon, 16 Mar 2020 12:50:00 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote:
> +static const ARMCPUInfo arm_v4_cpus[] = {
> + { .name = "ti925t", .initfn = ti925t_initfn },
> + { .name = "sa1100", .initfn = sa1100_initfn },
> + { .name = "sa1110", .initfn = sa1110_initfn },
> + { .name = NULL }
> +};
> +
> +static void arm_v4_cpu_register_types(void)
> +{
> + const ARMCPUInfo *info = arm_v4_cpus;
> +
> + while (info->name) {
> + arm_cpu_register(info);
> + info++;
> + }
> +}
I much prefer ARRAY_SIZE() to sentinels.
I know the existing code make much use of them,
but we don't need to replicate that here.
r~
- [PATCH v3 06/19] target/arm: Move Makefile variable restricted to CONFIG_TCG, (continued)
- [PATCH v3 06/19] target/arm: Move Makefile variable restricted to CONFIG_TCG, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 08/19] target/arm: Add semihosting stub to allow building without TCG, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 07/19] target/arm: Make cpu_register() available for other files, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 09/19] target/arm: Move ARM_V7M Kconfig from hw/ to target/, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 11/19] target/arm: Restrict ARMv5 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- Re: [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel,
Richard Henderson <=
- [PATCH v3 12/19] target/arm: Restrict ARMv6 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 13/19] target/arm: Restrict ARMv7 R-profile cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 14/19] target/arm: Restrict ARMv7 M-profile cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 15/19] target/arm: Make m_helper.c optional via CONFIG_ARM_V7M, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 16/19] target/arm: Do not build TCG objects when TCG is off, Philippe Mathieu-Daudé, 2020/03/16