[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v6 07/13] arm/arm64: ITS: its_enable_defaults
From: |
Auger Eric |
Subject: |
Re: [kvm-unit-tests PATCH v6 07/13] arm/arm64: ITS: its_enable_defaults |
Date: |
Wed, 11 Mar 2020 16:47:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Drew,
On 3/11/20 4:38 PM, Andrew Jones wrote:
> On Wed, Mar 11, 2020 at 02:51:11PM +0100, Eric Auger wrote:
>> +/* must be called after gicv3_enable_defaults */
>> +void its_enable_defaults(void)
>> +{
>> + int i;
>> +
>> + /* Allocate LPI config and pending tables */
>> + gicv3_lpi_alloc_tables();
>> +
>> + for (i = 0; i < nr_cpus; i++)
>> + gicv3_lpi_rdist_enable(i);
>
> You still haven't explained what's wrong with for_each_present_cpu.
The previous comment you did was related to a spurious change I made in
gicv3_lpi_alloc_tables. This change was removed in v5:
[kvm-unit-tests PATCH v5 05/13] arm/arm64: gicv3: Set the LPI config and
pending tables
I did not understand from your comment you wanted all locations to use
for_each_present_cpu(). I have nothing against it ;-)
Also,
> I see you've added 'i < nr_cpus' loops in arm/gic.c too. I'd prefer we not
> assume that all cpu's are present (even though, currently, they must be),
> because we may want to integrate cpu hotplug tests with these tests at
> some point.
OK
Thanks
Eric
>
>> +
>> + writel(GITS_CTLR_ENABLE, its_data.base + GITS_CTLR);
>> +}
>> --
>> 2.20.1
>>
>>
>
- [kvm-unit-tests PATCH v6 02/13] page_alloc: Introduce get_order(), (continued)
- [kvm-unit-tests PATCH v6 02/13] page_alloc: Introduce get_order(), Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 03/13] arm/arm64: gic: Introduce setup_irq() helper, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 04/13] arm/arm64: gicv3: Add some re-distributor defines, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 05/13] arm/arm64: gicv3: Set the LPI config and pending tables, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 06/13] arm/arm64: ITS: Introspection tests, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 08/13] arm/arm64: ITS: Device and collection Initialization, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 07/13] arm/arm64: ITS: its_enable_defaults, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 09/13] arm/arm64: ITS: Commands, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 10/13] arm/arm64: ITS: INT functional tests, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 11/13] arm/run: Allow Migration tests, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 12/13] arm/arm64: ITS: migration tests, Eric Auger, 2020/03/11
- [kvm-unit-tests PATCH v6 13/13] arm/arm64: ITS: pending table migration test, Eric Auger, 2020/03/11
- Re: [kvm-unit-tests PATCH v6 00/13] arm/arm64: Add ITS tests, Andrew Jones, 2020/03/11