[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests
From: |
Auger Eric |
Subject: |
Re: [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests |
Date: |
Wed, 11 Mar 2020 10:29:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Zenghui,
On 3/11/20 9:37 AM, Zenghui Yu wrote:
> Hi Eric,
>
> On 2020/3/10 22:54, Eric Auger wrote:
>> +#define GITS_TYPER_PLPIS BIT(0)
>> +#define GITS_TYPER_VLPIS BIT(1)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE GENMASK_ULL(7, 4)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE_SHIFT 4
>> +#define GITS_TYPER_IDBITS GENMASK_ULL(8, 12)
>
> Note that this should be GENMASK_ULL(12, 8).
definitively
Eric
>
>> +#define GITS_TYPER_IDBITS_SHIFT 8
>> +#define GITS_TYPER_DEVBITS GENMASK_ULL(13, 17)
>
> (17, 13)
>
>> +#define GITS_TYPER_DEVBITS_SHIFT 13
>> +#define GITS_TYPER_PTA BIT(19)
>> +#define GITS_TYPER_CIDBITS GENMASK_ULL(32, 35)
>
> (35, 32)
>
>> +#define GITS_TYPER_CIDBITS_SHIFT 32
>> +#define GITS_TYPER_CIL BIT(36)
>
> And please use tab for all of them.
>
>
> Thanks,
> Zenghui
>
- [kvm-unit-tests PATCH v5 00/13] arm/arm64: Add ITS tests, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 01/13] libcflat: Add other size defines, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 02/13] page_alloc: Introduce get_order(), Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 03/13] arm/arm64: gic: Introduce setup_irq() helper, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 04/13] arm/arm64: gicv3: Add some re-distributor defines, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 05/13] arm/arm64: gicv3: Set the LPI config and pending tables, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 07/13] arm/arm64: ITS: its_enable_defaults, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 08/13] arm/arm64: ITS: Device and collection Initialization, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 09/13] arm/arm64: ITS: Commands, Eric Auger, 2020/03/10
- [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests, Eric Auger, 2020/03/10