[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v4 07/13] arm/arm64: ITS: its_enable_defaults
From: |
Andrew Jones |
Subject: |
Re: [kvm-unit-tests PATCH v4 07/13] arm/arm64: ITS: its_enable_defaults |
Date: |
Mon, 9 Mar 2020 12:52:56 +0100 |
On Mon, Mar 09, 2020 at 12:45:34PM +0100, Auger Eric wrote:
> >> - for_each_present_cpu(cpu) {
> >> + for (cpu = 0; cpu < nr_cpus; cpu++) {
> >
> > You don't mention this change in the changelog.
> Hey, you can see the changelog is pretty long already & accurate. But
> you're right I missed that one and listing those changes too would have
> avoided me to put those changes in that patch.
>
> What's wrong with
> > using for_each_present_cpu() here?
> As you encouraged me to move the alloc into the it, I tried to do so but
> then discovered this was feasible for such kind of issue. At init time,
> CPUs have nott booted yet.
They may not have booted, but for_each_present_cpu() should still work
because the present mask is initialized at setup() time before the unit
test even starts.
Thanks,
drew
- Re: [kvm-unit-tests PATCH v4 03/13] arm/arm64: gic: Introduce setup_irq() helper, (continued)
- [kvm-unit-tests PATCH v4 08/13] arm/arm64: ITS: Device and collection Initialization, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 09/13] arm/arm64: ITS: Commands, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 10/13] arm/arm64: ITS: INT functional tests, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 11/13] arm/run: Allow Migration tests, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 12/13] arm/arm64: ITS: migration tests, Eric Auger, 2020/03/09
- [kvm-unit-tests PATCH v4 13/13] arm/arm64: ITS: pending table migration test, Eric Auger, 2020/03/09
- Re: [kvm-unit-tests PATCH v4 00/13] arm/arm64: Add ITS tests, Andrew Jones, 2020/03/09