[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/9] target/arm: Check addresses for disabled regimes
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 8/9] target/arm: Check addresses for disabled regimes |
|
Date: |
Thu, 5 Mar 2020 07:57:05 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/5/20 6:21 AM, Peter Maydell wrote:
>> if (regime_translation_disabled(env, mmu_idx)) {
>> - /* MMU disabled. */
>> + /*
>> + * MMU disabled. S1 addresses are still checked for bounds.
>> + * C.f. AArch64.TranslateAddressS1Off.
>> + */
>> + if (is_a64(env) && mmu_idx != ARMMMUIdx_Stage2) {
>
> This looks weird -- why do we care about whether the current
> EL is aarch64, rather than looking at the controlling EL
> for the translation regime ?
You're right, it should be the aa64-ness of the regime_el.
Thanks,
r~
- Re: [PATCH v2 1/9] target/arm: Replicate TBI/TBID bits for single range regimes, (continued)
- [PATCH v2 2/9] target/arm: Optimize cpu_mmu_index, Richard Henderson, 2020/03/02
- [PATCH v2 3/9] target/arm: Introduce core_to_aa64_mmu_idx, Richard Henderson, 2020/03/02
- [PATCH v2 4/9] target/arm: Apply TBI to ESR_ELx in helper_exception_return, Richard Henderson, 2020/03/02
- [PATCH v2 8/9] target/arm: Check addresses for disabled regimes, Richard Henderson, 2020/03/02
- [PATCH v2 6/9] target/arm: Use DEF_HELPER_FLAGS for helper_dc_zva, Richard Henderson, 2020/03/02
- [PATCH v2 5/9] target/arm: Move helper_dc_zva to helper-a64.c, Richard Henderson, 2020/03/02
- [PATCH v2 7/9] target/arm: Clean address for DC ZVA, Richard Henderson, 2020/03/02
- [PATCH v2 9/9] target/arm: Disable clean_data_tbi for system mode, Richard Henderson, 2020/03/02
- Re: [PATCH v2 0/9] target/arm: Misc cleanups surrounding TBI, Peter Maydell, 2020/03/05