qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/6] hw/arm/virt: Use VIRT_GIC_VERSION defines


From: Richard Henderson
Subject: Re: [PATCH v2 2/6] hw/arm/virt: Use VIRT_GIC_VERSION defines
Date: Sun, 1 Mar 2020 09:44:55 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 3/1/20 2:40 AM, Eric Auger wrote:
> +#define VIRT_GIC_VERSION_MAX    (-1)
> +#define VIRT_GIC_VERSION_HOST   0
> +#define VIRT_GIC_VERSION_2      2
> +#define VIRT_GIC_VERSION_3      3

Any reason this shouldn't be enum VirtGICType?

Anyway, this is an improvement.
Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]