Re: [PATCH] hw/arm: ast2400/ast2500: Wire up EHCI controllers

[Guenter Roeck]

On 2/7/20 12:16 AM, Cédric Le Goater wrote:
> On 2/6/20 7:34 PM, Guenter Roeck wrote:
> > Initialize EHCI controllers on AST2400 and AST2500 using the existing
> > TYPE_PLATFORM_EHCI. After this change, booting ast2500-evb into Linux
> > successfully instantiates a USB interface.
> >
> > ehci-platform 1e6a3000.usb: EHCI Host Controller
> > ehci-platform 1e6a3000.usb: new USB bus registered, assigned bus number 1
> > ehci-platform 1e6a3000.usb: irq 21, io mem 0x1e6a3000
> > ehci-platform 1e6a3000.usb: USB 2.0 started, EHCI 1.00
> > usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.05
> > usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
> > usb usb1: Product: EHCI Host Controller
>
> Cool. Have you tried to plug any devices ?

Yes, booting from USB drive works just fine. I already added it to my
test suite at kerneltests.org.

> > Signed-off-by: Guenter Roeck <address@hidden>
>
>
> This looks good. Could you add the AST2600 also ?

I thought about that, but how would I test it ? None of the ast2600
systems in the Linux kernel enables it. The devicetree include file for
ast2600 doesn't even have an entry for it. I could cook something up,
but that would not reflect real hardware.

Thanks,
Guenter