[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test
From: |
Auger Eric |
Subject: |
Re: [PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test |
Date: |
Tue, 28 Jan 2020 17:29:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Shameer,
On 1/17/20 6:45 PM, Shameer Kolothum wrote:
> Since we now have both pc-dimm and nvdimm support, update
> test_acpi_virt_tcg_memhp() to include those.
>
> Signed-off-by: Shameer Kolothum <address@hidden>
> ---
> tests/data/acpi/virt/NFIT.memhp | 0
> tests/data/acpi/virt/SSDT.memhp | 0
Is it normal to have those 2 above void files? I lost track about the
process.
> tests/qtest/bios-tables-test.c | 9 +++++++--
> 3 files changed, 7 insertions(+), 2 deletions(-)
> create mode 100644 tests/data/acpi/virt/NFIT.memhp
> create mode 100644 tests/data/acpi/virt/SSDT.memhp
>
> diff --git a/tests/data/acpi/virt/NFIT.memhp b/tests/data/acpi/virt/NFIT.memhp
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/data/acpi/virt/SSDT.memhp b/tests/data/acpi/virt/SSDT.memhp
> new file mode 100644
> index 0000000000..e69de29bb2
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index f1ac2d7e96..695d2e7fac 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -913,12 +913,17 @@ static void test_acpi_virt_tcg_memhp(void)
> };
>
> data.variant = ".memhp";
> - test_acpi_one(" -cpu cortex-a57"
> + test_acpi_one(" -machine nvdimm=on"
nit: maybe keep the same order as before ...
> + " -cpu cortex-a57"
> " -m 256M,slots=3,maxmem=1G"
and simply add ,nvdimm=on to above line.
> " -object memory-backend-ram,id=ram0,size=128M"
> " -object memory-backend-ram,id=ram1,size=128M"
> " -numa node,memdev=ram0 -numa node,memdev=ram1"
> - " -numa dist,src=0,dst=1,val=21",
> + " -numa dist,src=0,dst=1,val=21"
> + " -object memory-backend-ram,id=ram2,size=128M"
> + " -object memory-backend-ram,id=nvm0,size=128M"
> + " -device pc-dimm,id=dimm0,memdev=ram2,node=0"
> + " -device nvdimm,id=dimm1,memdev=nvm0,node=1",
> &data);
>
> free_test_data(&data);
>
Thanks
Eric
- [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback, (continued)
- [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback, Shameer Kolothum, 2020/01/17
- [PATCH v2 2/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length, Shameer Kolothum, 2020/01/17
- [PATCH v2 3/7] nvdimm: Use configurable ACPI IO base and size, Shameer Kolothum, 2020/01/17
- [PATCH v2 4/7] hw/arm/virt: Add nvdimm hot-plug infrastructure, Shameer Kolothum, 2020/01/17
- [PATCH v2 5/7] hw/arm/virt: Add nvdimm hotplug support, Shameer Kolothum, 2020/01/17
- [PATCH v2 6/7] tests: Update ACPI tables list for upcoming arm/virt test changes, Shameer Kolothum, 2020/01/17
- [PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test, Shameer Kolothum, 2020/01/17
- Re: [PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test,
Auger Eric <=
- Re: [PATCH v2 0/7] ARM virt: Add NVDIMM support, Auger Eric, 2020/01/28