[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH REPOST v3 09/80] arm/collie: use memdev for RAM
From: |
Andrew Jones |
Subject: |
Re: [PATCH REPOST v3 09/80] arm/collie: use memdev for RAM |
Date: |
Thu, 23 Jan 2020 13:27:04 +0100 |
On Thu, Jan 23, 2020 at 12:37:34PM +0100, Igor Mammedov wrote:
> memory_region_allocate_system_memory() API is going away, so
> replace it with memdev allocated MemoryRegion. The later is
> initialized by generic code, so board only needs to opt in
> to memdev scheme by providing
> MachineClass::default_ram_id
> and using MachineState::ram instead of manually initializing
> RAM memory region.
>
> PS:
> - while at it add check for user supplied RAM size and error
> out if it mismatches board expected value.
> - introduce RAM_ADDR_UFMT to avoid build errors on 32-bit hosts
> when specifying format string for ram_addr_t type
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> v2:
> * fix format string causing build failure on 32-bit host
> (Philippe Mathieu-Daudé <address@hidden>)
> v3:
> * instead of RAM_ADDR_UFMT adding use size_to_str()
> Philippe Mathieu-Daudé <address@hidden>
>
> CC: address@hidden
> CC: address@hidden
> CC: address@hidden
> ---
> hw/arm/collie.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
I don't know anything about collie, but I promised Igor to put
another pair of eyes on his changes. Looks fine to me.
Reviewed-by: Andrew Jones <address@hidden>